chore: expose websockets #2201
Merged
chore: expose websockets #2201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l platforms with UTP 2.0
…ame for UTP symbols
com.unity.netcode.gameobjects/Runtime/Transports/UTP/UnityTransport.cs
Outdated
Show resolved
Hide resolved
simon-lemay-unity
approved these changes
Sep 13, 2022
|
Should this be noted in the changelog? |
0xFA11
reviewed
Sep 13, 2022
Co-authored-by: Fatih Mar <[email protected]>
0xFA11
approved these changes
Sep 14, 2022
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
* chore: websockets. Minimalist UI to use WebSockets * fix: adjusting #ifdef on transport version to allow building non-webgl platforms with UTP 2.0 * fix: addressing build issue where WebGL platform requires different name for UTP symbols * fix: emitting a warning and switching to WebSockets if uers don't, on WebGL platform * Addressing PR review comments * Addressing PR review comments * Update com.unity.netcode.gameobjects/CHANGELOG.md Co-authored-by: Fatih Mar <[email protected]> Co-authored-by: Fatih Mar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is another step for https://jira.unity3d.com/browse/MTT-4522
It brings us to a point where
It doesn't yet cover:
As this is not ready on the Relay side.
In order to use WebSockets, user must check "Use Web Sockets":