test: Parenting manual test updates for PR-2146 #2207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code clarity. Co-authored-by: Jesse Olmer <[email protected]>
Code clarity. Co-authored-by: Jesse Olmer <[email protected]>
Setting WorldPositionStays when sending ParentSyncMessage in OnTransformParentChanged. To better handle late joining players with synchronizing NetworkObjects, added parent child sorting to the SceneEventData's synchronization serialization process. Added world position stays parameter to CreateLocalNetworkObject to preserve worldPostionStays.
Testing with and without WorldPositionStays.
This fixes some edge case scenarios and issues with parenting in-scene placed NetworkObjects. One in particular is to provide the local space position and rotation in ParentSyncMessage if the WorldPositionStays value is false. The server might maintain the original local space values and upon being reparented it re-applies the local space values. This is only pertinent if the user decides they don't want to use a NetworkTransform for the NetworkObject in question. Fixed an issue with despawning objects if the WorldPositionStaysTest fails during the integration test. Migrating this to teardown resolves the issue.
…on' into test/parenting-manual-test-updates-companion-pr-2146
…on' into test/parenting-manual-test-updates-companion-pr-2146
…on' into test/parenting-manual-test-updates-companion-pr-2146
…on' into test/parenting-manual-test-updates-companion-pr-2146
…on' into test/parenting-manual-test-updates-companion-pr-2146
…on' into test/parenting-manual-test-updates-companion-pr-2146
…on' into test/parenting-manual-test-updates-companion-pr-2146
jeffreyrainy
approved these changes
Oct 5, 2022
NoelStephensUnity
deleted the
test/parenting-manual-test-updates-companion-pr-2146
branch
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes some adjustments to the parenting manual test.
This is a companion PR to #2146.
Merge after #2146 is merged.
Testing and Documentation