fix: SceneEventProgress OnComplete not invoked on timeouts [MTT-4772] #2222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts-connected-logic-mtt-4772
Reducing the logic used to determine when the SceneEventProgress is finished. Renamed a few properties and methods for code readability purposes.
com.unity.netcode.gameobjects/Runtime/SceneManagement/ISceneManagerHandler.cs
Outdated
Show resolved
Hide resolved
…ts-connected-logic-mtt-4772
Added additional comments for clarity Fixed the logic behind determining when the SceneEventProgress should complete.
Added several tests to verify that SceneEventProgress will complete if all clients finished the scene event, if clients disconnect while it is still in progress, will time out if one or more clients never finish, and finally will still complete if one or more clients late join while it is still in progress.
…ts-connected-logic-mtt-4772
…ts-connected-logic-mtt-4772
ShadauxCat
reviewed
Sep 30, 2022
com.unity.netcode.gameobjects/Runtime/SceneManagement/ISceneManagerHandler.cs
Outdated
Show resolved
Hide resolved
ShadauxCat
reviewed
Sep 30, 2022
com.unity.netcode.gameobjects/Runtime/SceneManagement/SceneEventProgress.cs
Outdated
Show resolved
Hide resolved
…ts-connected-logic-mtt-4772
ShadauxCat
approved these changes
Oct 3, 2022
NoelStephensUnity
deleted the
fix/sceneeventprogress-timedout-and-clients-connected-logic-mtt-4772
branch
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
…Unity-Technologies#2222) * fix Need to track any clients that disconnected to add them to the list of clients that did not complete the scene event. Reducing the logic used to determine when the SceneEventProgress is finished. Renamed a few properties and methods for code readability purposes. Fixed the logic behind determining when the SceneEventProgress should complete. Renaming the SetSceneAsyncOperation to just SetAsyncOperation. * refactor Completely removed the entire SceneEventAction. Replaced it with an even more simplified version of SceneEventProgress. We will no longer allocate memory for SceneEventAction. * style Added additional comments for clarity fixing grammar in a comment removing two CR/LFs moving a comment above a few lines of code (otherwise it doesn't make sense). Last comment adjustment * test Added several tests to verify that SceneEventProgress will complete if all clients finished the scene event, if clients disconnect while it is still in progress, will time out if one or more clients never finish, and finally will still complete if one or more clients late join while it is still in progress.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses several issues with
SceneEventProgressthat could result in it never completing as well as several scenarios where it would never time out.MTT-4772
Changelog
SceneEventProgresswould not complete if a client late joins while it is still in progress.SceneEventProgresswould not complete if a client disconnects.SceneEventProgresshas timed out.Testing and Documentation
SceneEventProgressspecific integration tests.