fix: player objects do not honor the DontDestroyWithOwner property [MTT-4458] #2225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MTT-4458 The summary for DontDestroyWithOwner was incorrect. When true the NetworkObject's ownership is given back to the server.
ShadauxCat
approved these changes
Sep 30, 2022
NoelStephensUnity
deleted the
fix/dontdestroywithowner-on-playerobjects-mtt-4458
branch
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
…TT-4458] (Unity-Technologies#2225) * fix This fixes the issue with player objects not honoring the DontDestroyWithOwner property. The summary for DontDestroyWithOwner was incorrect. When true the NetworkObject's ownership is given back to the server. * test Adding a test to verify that when a client disconnects and the client's player object has DontDestroyWithOwner set to true that the NetworkObject's ownership is transferred back to the client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a client disconnects from the server the server will destroy their PlayerObject regardless of how DontDestroyWithOwner is set.
MTT-4458
#2138
Changelog
DontDestroyWithOwnerproperty into consideration when a client disconnected.Testing and Documentation