fix: NetworkConfig cached hash was not being regenerated on clients for each unique ConnectionRequestMessage [MTT-4605] #2226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadauxCat
approved these changes
Sep 30, 2022
NoelStephensUnity
deleted the
fix/networkconfig-cachec-hash-not-cleared-on-client-mtt-4605
branch
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
…or each unique ConnectionRequestMessage [MTT-4605] (Unity-Technologies#2226) MTT-4605 * fix This resolves the issue where clients would not regenerate their NetworkConfig's hash value if a client disconnected from one server and tried to join another server. * test This validates that passing false to the NetworkConfig.GetConfig method generates a unique hash value. * update updating the changelog entry with the PR number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a client first connects to one server, then later disconnects from that server, and then in the same runtime instance tries to connect to another server the NetworkConfig hash value would not be regenerated. This resolves that issue.
MTT-4605
#2175
Changelog
NetworkConfighash value for each unique connection request.Testing and Documentation