Skip to content

refactor: Migrate menu settings to project settings [MTT-5001] #2285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 2, 2022
Merged

refactor: Migrate menu settings to project settings [MTT-5001] #2285

merged 10 commits into from
Nov 2, 2022

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Oct 31, 2022 •
edited
Loading

This just moves the two netcode menu settings over to Netcode for GameObjects in project settings.

image

MTT-5001

Changelog

  • Added NetworkObject auto-add helper and Multiplayer Tools install reminder settings to Project Settings.
  • Removed the NetworkObject auto-add and Multiplayer Tools install reminder settings from the Menu interface.

Testing and Documentation

  • No tests have been added.
  • No documentation changes or additions were necessary.

@NoelStephensUnity
update
1be513c 
First pass work towards migrating the the Netcode for GameObjects settings from the menu to the project settings.
@NoelStephensUnity
update
e9ca523 
Migrated the multiplayer tools install reminder over to the new Netcode for GameObjects settings.
Deleted the UITestHelpers class completely as it is no longer needed.
@NoelStephensUnity
style
bb1ff14
@NoelStephensUnity
update
568d9af 
Updating the tooltip text for the auto-add NetworkObject helper.
@NoelStephensUnity
Merge branch 'develop' into feat/netcode-menu-settings-to-project-set…
94d2dbc 
…tings
@NoelStephensUnity
update
f338d42 
MTT-5001
updating the changelog
@NoelStephensUnity
update
3a0ffef 
MTT-5001
Adding PR number to changelog entries.
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner October 31, 2022 15:48
@NoelStephensUnity
update
743fd93 
MTT-5001
renamed branch to better reflect the type
adding new PR number to changelog entries.
@NoelStephensUnity
Merge branch 'develop' into refactor/netcode-menu-settings-to-project…
8e45911 
…-settings
0xFA11
0xFA11 reviewed Oct 31, 2022
View reviewed changes
Copy link
Contributor

@0xFA11 0xFA11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design-wise, it's a good direction I think but as it stands today, I wonder if it'd worth fragmenting "network settings" UX into 2 parts just for these options instead of keeping them under the still required NetworkManager inspector interface only.

@NoelStephensUnity
Copy link
Collaborator Author

Design-wise, it's a good direction I think but as it stands today, I wonder if it'd worth fragmenting "network settings" UX into 2 parts just for these options instead of keeping them under the still required NetworkManager inspector interface only.

Hmmm... interesting. I am all for migrating common settings outside of the NetworkManager UX.
Will try to grab your ear sometime after stand up to discuss/synch-up briefly. 👍

@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) November 1, 2022 23:58
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) November 2, 2022 00:04
@NoelStephensUnity NoelStephensUnity merged commit b4b3929 into develop Nov 2, 2022
@NoelStephensUnity NoelStephensUnity deleted the refactor/netcode-menu-settings-to-project-settings branch November 2, 2022 00:28
jakobbbb pushed a commit to GooseGirlGames/com.unity.netcode.gameobjects that referenced this pull request Feb 22, 2023
@NoelStephensUnity @jakobbbb
refactor: Migrate menu settings to project settings [MTT-5001] (Unity…
becdcd5 
…-Technologies#2285)

* update
Migrated the multiplayer tools install reminder over to the new Netcode for GameObjects settings.
Deleted the UITestHelpers class completely as it is no longer needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@0xFA11 0xFA11 0xFA11 left review comments

@jeffreyrainy jeffreyrainy jeffreyrainy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NoelStephensUnity @0xFA11 @jeffreyrainy