refactor: replace 3rd-party xxhash impl with in-house reimpl #2310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xFA11
commented
Nov 15, 2022
|
|
||
| namespace Unity.Netcode.EditorTests | ||
| { | ||
| public class XXHashTests |
There was a problem hiding this comment.
We never had unit tests to verify hash results, I implemented them with some hardcoded strings and expected hardcoded results.
Having said that, even though it's a full reimplementation of the 3rd-party one, they both give us the exact same results as expected as they are both completely valid and accurate implementations — we're just getting rid of our external dependency and also making them just slightly more performant/efficient.
NoelStephensUnity
approved these changes
Nov 15, 2022
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces 3rd-party xxHash32 & xxHash64 implementations with in-house full reimplementation.
Changelog
XXHash(32 & 64) implementation with an in-house reimplementationTesting and Documentation
XXHashTestsunit tests