fix: Fixed an issue where BatchedSendQueue was including the HeadIndex twice when copying data, which was causing stream corruption when the data exceeded a certain throughput. [NCCBUG-187] #2332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x twice when copying data, which was causing stream corruption when the data exceeded a certain throughput.
ShadauxCat
commented
Dec 2, 2022
| @@ -226,7 +226,7 @@ public int FillWriterWithMessages(ref DataStreamWriter writer) | |||
| { | |||
| writer.WriteInt(messageLength); | |||
|
|
|||
| var messageOffset = HeadIndex + reader.GetBytesRead(); | |||
| var messageOffset = reader.GetBytesRead(); | |||
There was a problem hiding this comment.
If you look above here, there's readerOffset = HeadIndex. This was changed in #2224 from readerOffset = 0 because reader was changed from being a slice of m_data to containing all of m_data and reading from that offset. The return value of GetBytesRead() here already includes HeadIndex, so this results in HeadIndex being applied twice when calculating messageOffset.
When HeadIndex is 0 that has no effect, but when the queue gets filled more, it starts resulting in things being skipped over, data being corrupted, and - sometimes - data from completely outside the stream (i.e., garbage data) being copied into the stream.
NoelStephensUnity
approved these changes
Dec 5, 2022
ShadauxCat
deleted the
fix/BatchedSendQueue_calculating_HeadIndex_twice
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Testing and Documentation