fix: registry of public NetworkVariables in derived NetworkBehaviours
#2423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xFA11
changed the title
NetworkVariable fields of derived NetworkBehaviour classes
0xFA11
changed the title
NetworkVariable fields of derived NetworkBehaviour classesNetworkVariables of derived NetworkBehaviours
0xFA11
changed the title
NetworkVariables of derived NetworkBehavioursNetworkVariables in derived NetworkBehaviours
| public IEnumerator TestInheritedFields() | ||
| { | ||
| yield return WaitForConditionOrTimeOut(CheckTestObjectComponentValuesOnAll); | ||
| Assert.IsFalse(s_GlobalTimeoutHelper.TimedOut, nameof(CheckTestObjectComponentValuesOnAll)); |
There was a problem hiding this comment.
(just informational)
You can also do the same thing this way after a WaitForConditionOrTimeOut:
AssertOnTimeout(nameof(CheckTestObjectComponentValuesOnAll));
NoelStephensUnity
approved these changes
Feb 24, 2023
NoelStephensUnity
added a commit
that referenced
this pull request
Mar 1, 2023
NoelStephensUnity
added a commit
that referenced
this pull request
Mar 1, 2023
* update Adding new unreleased section. Migrated #2423 into the unreleased section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #2417, originally suggested by @JayPeet.