fix: Metrics: Exception when tracking Named Messages [MTT-5380] #2426
Conversation
There was a problem hiding this comment.
Nice fix.
The last thing you need to do is add an update to the changlog file. Take a look at some of my pending PRs to get an idea of how to handle this while we are still in the middle of a release. It requires the existing changelog entries fall under a v1.3.0 entry and a new [Unreleased] section.
(it is easier to refrain from merging PRs until the release is finalized to avoid having to go back and pull out the PRs not included in the v1.3.0 release)
Thanks! I've updated the Changelog. |
samlucas-unity
changed the title
| @@ -36,6 +36,7 @@ Additional documentation and release notes are available at [Multiplayer Documen | |||
| - Fixed `NetworkAnimator` issue with using pooled objects and when specific properties are cleaned during despawn and destroy.(#2309) | |||
| - Fixed issue where `NetworkAnimator` was checking for animation changes when the associated `NetworkObject` was not spawned.(#2309) | |||
| - Corrected an issue with the documentation for BufferSerializer (#2401) | |||
| - Fixed an issue where Named Message Handlers could remove themselves causing an exception when the metrics tried to access the name of the message.(#2394) | |||
There was a problem hiding this comment.
| - Fixed an issue where Named Message Handlers could remove themselves causing an exception when the metrics tried to access the name of the message.(#2394) | |
| - Fixed an issue where Named Message Handlers could remove themselves causing an exception when the metrics tried to access the name of the message. (#2426) |
The number at the end is not for GitHub Issue number, it's for the PR number :)
There was a problem hiding this comment.
Cheers! Noel spotted it too, you beat me to it :)
0xFA11
changed the title
This PR fixes an issue where Named Message Handlers could remove themselves causing an exception when the metrics tried to access the name of the message.
Metrics: Exception when tracking Named Messages in NGO [MTT-5380]
Github Issue: #2394
Changelog