fix: integration tests and NetworkTransform teleport issue #2451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reducing NetworkAnimator tests time. Fixing an issue with the network config hash internally stored value not clearing when the server-host or the client shutsdown in the event that prefabs change depending upon the network session being connected to. Making sure NetworkAnimatorTests.ShutdownWhileSpawnedAndStartBackUpTest fails if the client cannot reconnect after shutting down.
NoelStephensUnity
changed the title
Trying to resolve issue where Mac on 2020.3 seems to not have enough time when interpolating. This update provides a new TimeOutHelper derived class TimeoutFrameCountHelper that requires the expected number of frames to pass and the time out period to be reached before it considers the condition check timed out.
removing white space migrating some initialization into TransformInterpolationObject for TransformInterpolationTests
ShadauxCat
approved these changes
Mar 16, 2023
Adding some additional checks as well as providing additional information about time and frame count in NestedNetworkTransformTests.
NoelStephensUnity
deleted the
fix/integrationtest-specific-defines-for-consoles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding additional define check for console/stand alone test runner based integration tests.
Reducing the over-all time to execute tests.
Fixing an issue with NetworkAnimatorTests.ShutdownWhileSpawnedAndStartBackUpTest not properly reconfiguring all clients as well as making NetworkConfig's cached hash value not persist after shutting down. If the NetworkConfig cached hash is not cleared when NetworkManager shuts down and a client attempts to connect to a new session where the user application knows that the server being connected to has different/alternate prefabs (i.e. the prefab list is modified) it would cause the client to not be able to connect.
Fixing an issue where NetworkTransform teleporting could have potentially been overwritten by a change in state prior to the next network tick update. Adjusted NetworkTransformStateTests to account for this fix.
Testing and Documentation