Skip to content

fix: NGO UnityTransport not detecting invalid endpoint [MTT-3937] #2496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 10, 2023
Merged

fix: NGO UnityTransport not detecting invalid endpoint [MTT-3937] #2496

merged 7 commits into from
Apr 10, 2023

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Apr 7, 2023 •
edited
Loading

This resolves the issue where the NGO UnityTransport class was not detecting an invalid endpoint address and would always return true (even with an invalid endpoint address).

MTT-3937
Also pertains to issue #2525

Changelog

  • Fixed: Issue where invalid endpoint addresses were not being detected and returning false from NGO UnityTransport.

Testing and Documentation

  • Includes unit test.
  • No documentation changes or additions were necessary.

@NoelStephensUnity
fix
1c6116b 
detect and return early if trying to bind to an invalid endpoint.
@NoelStephensUnity
test
7e66bcd 
Adding a unit test to validate the fix.
@NoelStephensUnity
Merge branch 'develop' into fix/not-detecting-invalid-endpoint-mtt-3937
a6af280
@NoelStephensUnity
update
210f748 
updating changelog entry
@NoelStephensUnity NoelStephensUnity requested review from a team as code owners April 7, 2023 20:55
@NoelStephensUnity
update
2fbc43b 
Adding the PR number to changelog entry
@NoelStephensUnity
update
c8e3ea1 
Minor tweaks to NetcodeLogAssert.
Updating test to detect invalid endpoint.
@NoelStephensUnity
test fix
fccabeb 
Fixing the editor test expecting a error log that no longer will happen with an invalid endpoint address.
@NoelStephensUnity NoelStephensUnity merged commit 4abf5a1 into develop Apr 10, 2023
@NoelStephensUnity NoelStephensUnity deleted the fix/not-detecting-invalid-endpoint-mtt-3937 branch April 10, 2023 21:48
@NoelStephensUnity NoelStephensUnity mentioned this pull request May 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShadauxCat ShadauxCat ShadauxCat approved these changes

@johann-r-unity johann-r-unity johann-r-unity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NoelStephensUnity @ShadauxCat @johann-r-unity