fix: Memory leak in UnityTransport after StartClient failure

[simon-lemay-unity]

If StartClient failed, then the driver would not be created. But if the driver is not created, we exit early in Shutdown which prevents us from disposing of the network settings and send queue (if any). This would result in a memory leak. The fix is simply to always dispose of these resources in Shutdown, without guarding it with a check on the driver.

One simple way to trigger that memory leak would be to start a client with an invalid IP address.

Changelog

• Fixed: Fixed a memory leak in UnityTransport that occurred if StartClient failed.

Testing and Documentation

• Includes unit test.
• No documentation changes or additions were necessary.

[NoelStephensUnity]

Looks good.
I thought I had added a test for the client failing with a bad address... but glad you caught that!
👍