fix: Add ILPP error-handling to catch managed INetworkSerializables that don't meet the new() constraint so they won't crash the editor [MTT-6211]
#2528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat don't meet the `new()` constraint so they won't crash the editor
ShadauxCat
changed the title
new() constraint so they won't crash the editornew() constraint so they won't crash the editor [MTT-6211]
0xFA11
reviewed
Apr 25, 2023
com.unity.netcode.gameobjects/Editor/CodeGen/NetworkBehaviourILPP.cs
Outdated
Show resolved
Hide resolved
…LPP.cs Co-authored-by: Fatih Mar <[email protected]>
0xFA11
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2445
Changelog
NetworkVariablewith anINetworkSerializabletype that doesn't meet thenew()constraint will now create a compile-time error instead of an editor crashTesting and Documentation