Skip to content

fix: server scene exclusion during synchronization for runtime generated scenes #2550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented May 4, 2023

This fix provides users with the ability to use NetworkSceneManager.VerifySceneBeforeLoading to exclude runtime generated scenes from being included in the scenes to be synchronized during the initial client synchronization.

Based on PR-2442 submitted by user @brogan89

Changelog

  • Fixed: issue where users could not use NetworkSceneManager.VerifySceneBeforeLoading to exclude runtime generated scenes from client synchronization.

Testing and Documentation

  • Includes integration test.
  • No documentation changes or additions were necessary.

Breaking apart the ValidateSceneBeforeLoading so synchronization can exclude runtime generated scenes.
Added comment
Test to validate the fix for the server being able to use NetworkSceneManager.VerifySceneBeforeLoading in order to exclude scenes created at runtime.
Updating the changelog file to reflect the fix
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review May 4, 2023 21:29
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner May 4, 2023 21:29
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) May 19, 2023 13:09
@NoelStephensUnity NoelStephensUnity merged commit 0ba6837 into develop May 19, 2023
@NoelStephensUnity NoelStephensUnity deleted the fix/validatescenebeforeloading-synchronization branch May 19, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants