Skip to content

fix: missing value on NetworkListEvent for EventType.RemoveAt events [MTT-6354] #2559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 12, 2023
Merged

fix: missing value on NetworkListEvent for EventType.RemoveAt events [MTT-6354] #2559

merged 4 commits into from
May 12, 2023

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented May 12, 2023 •
edited
Loading

Resolve #2542

This PR adds the value on NetworkListEvent for EventType.RemoveAt events server side.
The code for server is now the same as in ReadDelta function used by the client.

MTT-6354

Changelog

  • Fixed: missing value on NetworkListEvent for EventType.RemoveAt events server side.

Testing and Documentation

  • Includes integration test NetworkVariableTest updates.
  • No documentation changes or additions were necessary.

@NoelStephensUnity NoelStephensUnity mentioned this pull request May 12, 2023
Closed
NoelStephensUnity and others added 3 commits May 12, 2023 10:53
@NoelStephensUnity
Update CHANGELOG.md
1de9713
@NoelStephensUnity
test
ca4bc47 
Updated the NetworkList remove tests to be combined into one test and to validate that the list changed event is returning the value of the element removed.

Cleaned up the tests a bit and removed some legacy tests that were being ignored and no longer serve a purpose.
@NoelStephensUnity
Merge branch 'fix/networklist-event-removeat-user-submitted-2543' of h…
404fac5 
…ttps://github.com/Unity-Technologies/com.unity.netcode.gameobjects into fix/networklist-event-removeat-user-submitted-2543
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review May 12, 2023 16:44
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner May 12, 2023 16:44
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) May 12, 2023 16:52
@NoelStephensUnity NoelStephensUnity changed the title fix: missing value on NetworkListEvent for EventType.RemoveAt events … fix: missing value on NetworkListEvent for EventType.RemoveAt events [MTT-6354] May 12, 2023
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) May 12, 2023 17:00
@NoelStephensUnity NoelStephensUnity merged commit 688640c into develop May 12, 2023
@NoelStephensUnity NoelStephensUnity deleted the fix/networklist-event-removeat-user-submitted-2543 branch May 12, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShadauxCat ShadauxCat ShadauxCat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NetworkListEvent miss value for EventType.RemoveAt events server side
3 participants
@NoelStephensUnity @ShadauxCat @PitouGames