Skip to content

fix: ilpp stripping and coreclr compatibility [NCCBUG-209] #2614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jul 21, 2023
Merged

fix: ilpp stripping and coreclr compatibility [NCCBUG-209] #2614

merged 21 commits into from
Jul 21, 2023

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Jul 10, 2023 •
edited
Loading

This update fixes a few issues encountered with dedicated server builds and coreclr usage.

MTT-6798
NCCBUG-209
NCCBUG-208

fixes: #2597

Changelog

-Fixed: ILPP issues when using CoreCLR and for certain dedicated server builds.

Testing and Documentation

  • No tests have been added.
  • No documentation changes or additions were necessary.

NoelStephensUnity and others added 8 commits June 13, 2023 20:50
@NoelStephensUnity
update
843b735 
excluding getTypeName,
@NoelStephensUnity
update
e768a58 
Make sure internal classes can access NetworkBehaviour.NetworkVariableFields in runtime builds.
@NoelStephensUnity
update
784c926 
to get RPCS working temporarily.
@NoelStephensUnity
style
89c5505 
Adding comments about the RPC stuff since it is a bit more complicated than the previous two issues.
@NoelStephensUnity
style
42cfe6a 
updating and adding comments to regions of code changed in order to easily distinguish the changes made for each issue type.
@NoelStephensUnity
update
55ceee8 
Missed two files.
@ShadauxCat
Updated the ILPP code to work correctly with CoreCLR:
f2d2b30 
- delegates are no longer fields, but types
- internal virtual functions can't be overridden in child classes anymore, so they have to be changed from `IsAssembly` to `IsFamilyOrAssembly` in ILPP
- Internal fields changed to `IsFamily` can no longer be accessed within the assembly, and need to be `IsFamilyOrAssembly` instead.

With those changes, previous workarounds are no longer needed, so I reverted them.
@NoelStephensUnity
Merge branch 'develop' into experimental/ngo-exclude-gettypename
6dbae46
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner July 10, 2023 23:04
NoelStephensUnity and others added 3 commits July 10, 2023 18:13
@NoelStephensUnity
update
576fe99 
removing commented out code.
wrapping the rpc table generation log info so it only logs to the console when log mode is set to developer.
@NoelStephensUnity
style
49f7735 
Fixing whitespace issue.
@ShadauxCat
revert __RpcParams to internal
6e968c9
@NoelStephensUnity NoelStephensUnity mentioned this pull request Jul 11, 2023
Closed
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) July 21, 2023 01:38
@NoelStephensUnity NoelStephensUnity merged commit 6d461bf into develop Jul 21, 2023
@NoelStephensUnity NoelStephensUnity deleted the fix/ilpp-stripping-and-coreclr-compatibility branch July 21, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShadauxCat ShadauxCat ShadauxCat approved these changes

@chrispope chrispope chrispope approved these changes

@TylerUnity TylerUnity Awaiting requested review from TylerUnity

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@NoelStephensUnity @ShadauxCat @chrispope