Skip to content

fix: shutdown causes exception if invoked twice [MTT-6752] #2622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 12, 2023
Merged

fix: shutdown causes exception if invoked twice [MTT-6752] #2622

merged 6 commits into from
Jul 12, 2023

Conversation

NoelStephensUnity
Copy link
Collaborator

This fixes the issue where invoking shutdown a second time (within a specific time frame) could throw an exception.

MTT-6752

Changelog

  • Fixed: issue where invoking NetworkManager.Shutdown multiple times, depending upon the timing, could cause an exception.

Testing and Documentation

  • Includes integration tests.
  • No documentation changes or additions were necessary.

@NoelStephensUnity
fix
04db713 
This fixes the issue with shutdown throwing an exception when being invoked again within the shutdown callback.
@NoelStephensUnity
test
2a816a6 
This validates the fix
@NoelStephensUnity
Merge branch 'develop' into fix/shutdown-causes-exception-if-invoked-…
b5030ba 
…twice-MTT-6752
@NoelStephensUnity
update
537051b 
added changelog entry and made minor adjustments to existing entry.
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review July 12, 2023 16:53
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner July 12, 2023 16:53
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) July 12, 2023 21:47
@NoelStephensUnity NoelStephensUnity merged commit 9ca4efb into develop Jul 12, 2023
@NoelStephensUnity NoelStephensUnity deleted the fix/shutdown-causes-exception-if-invoked-twice-MTT-6752 branch July 12, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShadauxCat ShadauxCat ShadauxCat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoelStephensUnity @ShadauxCat