-
Notifications
You must be signed in to change notification settings - Fork 455
fix: 32bit-ARMv7 crashes on android #2654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 32bit-ARMv7 crashes on android #2654
Conversation
com.unity.netcode.gameobjects/Runtime/Messaging/CustomMessageManager.cs
Outdated
Show resolved
Hide resolved
…d some extra safety logic on both read and write sides.
com.unity.netcode.gameobjects/Tests/Runtime/Metrics/TransportBytesMetricsTests.cs
Outdated
Show resolved
Hide resolved
reverting the switch to 32 bit hash values.
reverting the conditional registration of either 32bit or 64 bit hash values in either table to just register in both tables.
Will let you decide if you think it's worth the hit to readability, but you can calculate aligned lengths this way: alignedLength = (length + 7) & ~7; It avoids dealing with floating points and only uses fast integer instructions. |
Oh good point. +1 to this @NoelStephensUnity |
This PR resolves the issue with ARMv7 builds crashing on the Android.
fix: #2646
Changelog
Testing and Documentation