Skip to content

fix: Fixes "writing past the end of the buffer" error when calling ResetDirty() on managed network variables that are larger than 256 bytes when serialized. #2670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ShadauxCat
Copy link
Collaborator

fixes #2655

Changelog

  • Fixed: Fixed "writing past the end of the buffer" error when calling ResetDirty() on managed network variables that are larger than 256 bytes when serialized.

Testing and Documentation

  • No tests have been added.
  • No documentation changes or additions were necessary.

…setDirty() on managed network variables that are larger than 256 bytes when serialized.

fixes #2655
@ShadauxCat ShadauxCat requested a review from a team as a code owner August 21, 2023 19:46
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ShadauxCat ShadauxCat merged commit cea4486 into develop Aug 22, 2023
@ShadauxCat ShadauxCat deleted the fix/writing_past_end_of_buffer_in_networkvariable_duplicate branch August 22, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New "Writing past the end of the buffer" issue in 1.5.1/1.5.2 (worked in 1.4.0) serializing a list of objects containing FixedString64Bytes
2 participants