Skip to content

fix: Compile error when a class with Rpcs inherits from an intermediate base class with no Rpcs. #2751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 27, 2023
Merged

fix: Compile error when a class with Rpcs inherits from an intermediate base class with no Rpcs. #2751

merged 4 commits into from
Oct 27, 2023

Conversation

ShadauxCat
Copy link
Collaborator

Changelog

  • Fixed: Fixed a bug where having a class with Rpcs that inherits from a class without Rpcs that inherits from NetworkVariable would cause a compile error.

Testing and Documentation

  • Includes unit tests.
  • No documentation changes or additions were necessary.

@ShadauxCat ShadauxCat requested a review from a team as a code owner October 26, 2023 20:30
@ShadauxCat ShadauxCat changed the title Fix: Compile error when a class with Rpcs inherits from an intermediate base class with no Rpcs. fix: Compile error when a class with Rpcs inherits from an intermediate base class with no Rpcs. Oct 26, 2023
NoelStephensUnity
NoelStephensUnity approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NoelStephensUnity NoelStephensUnity merged commit 4e246ff into develop Oct 27, 2023
@NoelStephensUnity NoelStephensUnity deleted the fix/initializeRpcs_compile_error branch October 27, 2023 20:18
PitouGames added a commit to PitouGames/com.unity.netcode.gameobjects that referenced this pull request Nov 13, 2023
@PitouGames
fix: Compile error when a class with Rpc inherits from an intermediat…
4f1603a 
…e base class with no Rpc. (Unity-Technologies#2751)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoelStephensUnity NoelStephensUnity NoelStephensUnity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShadauxCat @NoelStephensUnity