Skip to content

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Apr 25, 2025

Do Not Merge Until...

  • Referenced assemblies are checked for tools integration project (if we keep this).
  • If we don't keep tools integration project, make sure this PR includes the removal of the project in YAML.
  • PR-720 is passing.

PVP Fixes

This includes some (not all) fixes for:
PVP-133-2
PVP-130-2

Depends upon PR-720

Changelog

NA

Testing and Documentation

  • No tests have been added.
  • No documentation changes or additions were necessary.

Backport

A backport similar to this will be required but will not be these specific changes.

This includes some (not all) fixes for:
PVP-133-2
PVP-130-2
Removing space at end of line.
Minor private comment fixes.
Updating manifest to do a test run with the modified tools repository/
Removing all of the tools related tests from NGO package.
Removing the scene event tests.
Missed one internal visibility even though it doesn't impact anything (yet).
@NoelStephensUnity
Copy link
Collaborator Author

Closing this pull request as it has been replaced by #3444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant