Skip to content

Conversation

EmandM
Copy link
Collaborator

@EmandM EmandM commented May 24, 2025

MTT-12308

Changelog

  • Fixed: Initial connection flow with CMB Service and scene management enabled

Testing and Documentation

  • Includes unit tests.

Backport

Not needed.

Fixes an issue with CMB Service so this is 2.0 only functionality.

@EmandM EmandM marked this pull request as ready for review May 26, 2025 20:32
@EmandM EmandM requested a review from a team as a code owner May 26, 2025 20:32
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need a walk through on the synchronization event.

EmandM and others added 8 commits May 28, 2025 14:43
… (develop-2.0.0) (#3461)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| RecipeEngine.Modules.Wrench | nuget | patch | `0.10.49` -> `0.10.50` |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Unity Renovate
Bot](https://internaldocs.unity.com/renovate/).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIwLjAuMC1zZW1hbnRpYy1yZWxlYXNlIiwidXBkYXRlZEluVmVyIjoiMC4wLjAtc2VtYW50aWMtcmVsZWFzZSIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AtMi4wLjAiLCJsYWJlbHMiOltdfQ==-->

## Backport

#3460 (review)

Co-authored-by: unity-renovate[bot] <120015202+unity-renovate[bot]@users.noreply.github.com>
…(develop-2.0.0) (#3464)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| RecipeEngine.Modules.Wrench | nuget | minor | `0.10.50` -> `0.11.1` |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Unity Renovate
Bot](https://internaldocs.unity.com/renovate/).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIwLjAuMC1zZW1hbnRpYy1yZWxlYXNlIiwidXBkYXRlZEluVmVyIjoiMC4wLjAtc2VtYW50aWMtcmVsZWFzZSIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AtMi4wLjAiLCJsYWJlbHMiOltdfQ==-->

## Backport

#3463

Co-authored-by: unity-renovate[bot] <120015202+unity-renovate[bot]@users.noreply.github.com>
@EmandM EmandM requested a review from a team as a code owner May 28, 2025 20:49
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice integration tests... :godmode:

  • The PR still needs a "Fix" change log entry.
  • There is a question about the commented out code block.

Other than those two minor things...
Looks good to me!
👍

@EmandM EmandM enabled auto-merge (squash) June 2, 2025 15:00
@EmandM EmandM merged commit e24c2e5 into develop-2.0.0 Jun 2, 2025
42 checks passed
@EmandM EmandM deleted the fix/mttb-12308/client-connection-flow branch June 2, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants