fix: dont destroy with owner not being honored when client exits #3477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoelStephensUnity
added
the
port:1.x-completed
…ng-honored-when-client-exits
EmandM
approved these changes
Jun 2, 2025
com.unity.netcode.gameobjects/Runtime/Connection/NetworkConnectionManager.cs
Show resolved
Hide resolved
…d-when-client-exits
…d-when-client-exits
NoelStephensUnity
added a commit
that referenced
this pull request
Jun 3, 2025
…t Backport of 3477] (#3478) The v1.x branch does not have the same issue as #3477. This PR is only the backport of the test added to 3477 to assure we have the same kind of coverage in both versions. ## Changelog NA ## Testing and Documentation - Includes integration test `NetworkObjectDontDestroyWithOwnerTests.NetworkShowThenClientDisconnects`. - No documentation changes or additions were necessary. <!-- Uncomment and mark items off with a * if this PR deprecates any API: ### Deprecated API - [ ] An `[Obsolete]` attribute was added along with a `(RemovedAfter yyyy-mm-dd)` entry. - [ ] An [api updater] was added. - [ ] Deprecation of the API is explained in the CHANGELOG. - [ ] The users can understand why this API was removed and what they should use instead. --> ## Backport This is a test-only backport of #3477. <!-- If this is a backport: - Add the following to the PR title: "\[Backport\] ..." . - Link to the original PR. If this needs a backport - state this here If a backport is not needed please provide the reason why. If the "Backports" section is not present it will lead to a CI test failure. -->
EmandM
deleted the
fix/dont-destroy-with-owner-not-being-honored-when-client-exits
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on issue #3472, this PR resolves the issue where the
NetworkObject.DontDestroyWithOwnerwas not being honored.Changelog
NetworkObject.DontDestroyWithOwnerwas not being honored.Testing and Documentation
NetworkObjectDontDestroyWithOwnerTests.NetworkShowThenClientDisconnects.Backport
The v1.x branch does no have this issue, but went ahead and backported the test in #3478.