fix: globalobjectidhash printing in editor, remove istestrun flag #774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesseOlmer
suggested changes
Apr 26, 2021
| private void OnValidate() | ||
| { | ||
| if (UnityEditor.EditorApplication.isPlayingOrWillChangePlaymode && !NetworkManager.IsTestRun) | ||
| if (UnityEditor.EditorApplication.isPlaying && !string.IsNullOrEmpty(gameObject.scene.name)) |
There was a problem hiding this comment.
Could you add some comments explaining why we're early-outing in both of these cases?
There was a problem hiding this comment.
we already have tests covering this and the tests found this issue are on the way here: #754
There was a problem hiding this comment.
it's very tricky to comment these flows inline here, I might try.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes
bool NetworkManager.IsTestRunentirely as it is no longer needed.fixes
GlobalObjectIdHashconsistency issue in the Editor (as we found with Noel during tests).