Allow pasing array of objects to CreatePool, such as from a sceneobje… #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct. This is to allow the use of scene objects containing such an array of prefabs, which is supposed to be quicker to create than calling instantiate.
|
Turns out this is useless the way I intended to use it. You can pass in an array of prefabs, but if they are references in a scene object there's no way to change the active states (unless you're in the editor, but that's not what we want.) |
|
The feature was removed anyways during the object pool rework |
|
For my own education, I got it working using actual de-activated scene objects, not prefab references, and one actual prefab for instantiation when expanding the pool since that is a little quicker than cloning a GameObject. It's pretty academic. The number of objects you'd have to be loading to be worth the improvement is impractical to set up this way. |
MrCool92
pushed a commit
to MrCool92/MLAPI
that referenced
this pull request
Dec 6, 2020
Allow pasing array of objects to CreatePool, such as from a sceneobje…
0xFA11
added a commit
that referenced
this pull request
Feb 24, 2021
* implement NetworkUpdateLoop * remove AdvanceFrame() and FrameCount * update player loop injection points and INetworkUpdateSystem API * add xmldoc and notes * add NetworkUpdateLoopTests * implement NetworkUpdateLoop plain and mixed tests * update xmldoc * small meta fix * replace old network update loop with new RFC-backed network update loop * replace WaitForEndOfFrame with WaitUntil in tests * comment 'default' for NetworkUpdateStage.Update enum value * optimization & refactoring pass * dictionary lookups instead of index access to arrays * optimize array allocation
jeffreyrainy
pushed a commit
that referenced
this pull request
Feb 24, 2021
* implement NetworkUpdateLoop * remove AdvanceFrame() and FrameCount * update player loop injection points and INetworkUpdateSystem API * add xmldoc and notes * add NetworkUpdateLoopTests * implement NetworkUpdateLoop plain and mixed tests * update xmldoc * small meta fix * replace old network update loop with new RFC-backed network update loop * replace WaitForEndOfFrame with WaitUntil in tests * comment 'default' for NetworkUpdateStage.Update enum value * optimization & refactoring pass * dictionary lookups instead of index access to arrays * optimize array allocation
becksebenius-unity
added a commit
that referenced
this pull request
Aug 31, 2021
becksebenius-unity
added a commit
that referenced
this pull request
Aug 31, 2021
* Implemented NetworkMessageSent/NetworkMessageReceived metrics * Added tests and fixed missing messages during batching * updated the message type names to be a readonly * fix against latest develop merge * bumped tools version to #8 * fixed unnecessary using * fixed errant tab (thanks github merge....)
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
* Implemented NetworkMessageSent/NetworkMessageReceived metrics * Added tests and fixed missing messages during batching * updated the message type names to be a readonly * fix against latest develop merge * bumped tools version to Unity-Technologies#8 * fixed unnecessary using * fixed errant tab (thanks github merge....)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ct. This is to allow the use of scene objects containing such an array of prefabs, which is supposed to be quicker to create than calling instantiate.