Actions ref PR 5 #568
Merged
Actions ref PR 5 #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
September 2, 2024 09:23
Some of those are guesses, but they'll do for now. I'll tidy it up again later. Not sure the Shift feature still exists; asked about it.
Gabe confirmed that yesterday
Gabe approved
But I have some questions
I was using a couple of wrong files. Also, I'm killing the Tools vs Actions page. First of all, we can't keep calling them actions because Actions is a category of Actions, and we can't do that to our poor users. Second, this page duplicates information that's better presented in its own context, such as creating meshes and the so-called actions. The conceptual difference between tool and action is really not something users need to worry themselves with.
Got rid of the inset page, because it's just a way to use Extrude
So I removed it
|
Sue Arkin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
suearkinunity
changed the base branch from
master
to
suearking-DOCATT-5849-2
JonMUnity
reviewed
Sep 13, 2024
Documentation~/Face_Extrude.md
Outdated
Comment on lines
26
to
32
| | **Property** | | **Description** | | ||
| | :--- | --- | --- | | ||
| | **Extrude By** | | When you extrude more than one face, and those faces share an edge, set how the new faces behave along the shared edge. | | ||
| |  | **Face Normals** | Each new face follows the direction of its original face, and the faces are connected to each other. | | ||
| |  | **Vertex Normals** | The edges of the new faces farthest from the joint edge follow the direction of the original faces. However, the faces move toward the shared edge rather than follow the original direction for their whole length. | | ||
| |  | **Individual Faces** | Each new face follows the direction of its original face, but the faces aren't connected to each other. | | ||
| | **Distance** | | Distance to extrude the faces(s). Use negative values to inset the face, and define inset. | |
There was a problem hiding this comment.
This table is busted. I think the icons have to go in the same column as the title. For example,
| |  **Face Normals** | Each new face follows the direction of its original face, and the faces are connected to each other. |
| From the main menu, select **Tools** > **ProBuilder** > **Selection** > **Select Vertex Color**. | ||
| 1. In the **Tools** overlay, select the **ProBuilder** context. | ||
| 1. In the **Tool Settings** overlay, select an edit mode. All three modes support this action. | ||
| 1. Select an element. To select more than one color, hold **Shift** and select more elements. <!--this isn't as simple as I make it sound - when you select an edge or a vertex, it's not obvious which face it will reference for the color - it's honestly easier to use only Face mode--> |
There was a problem hiding this comment.
We need to remove the code comments. They display in the published source of the output.
There was a problem hiding this comment.
I don't remove comments until right before we merge, unless they're dealt with.
|
Merging into my other PR because frankly this is confusing me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
More changes to the actions refrences.
Links
Jira: DOCATT-5849
Comments to Reviewers
Note that most of the files here have no content changes - I just removed the image from their header, because that was an icon from the ProBuilder Toolbar.
I also have no idea why the two material files ended up here - perhaps Mod can remove them from the PR?