Add --namespace-packages to mypy for mlagents #3075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
December 7, 2019 15:04
chriselion
commented
Dec 11, 2019
| @@ -57,6 +57,7 @@ def __init__(self, seed, brain, trainer_parameters): | |||
| self.brain = brain | |||
| self.use_recurrent = trainer_parameters["use_recurrent"] | |||
| self.memory_dict: Dict[str, np.ndarray] = {} | |||
| self.reward_signals: Dict[str, "RewardSignal"] = {} | |||
There was a problem hiding this comment.
Used the string form here, because importing RewardSignal was leading to circular imports.
chriselion
commented
Dec 11, 2019
| @@ -1,6 +1,6 @@ | |||
| from typing import NamedTuple, Any, Dict, Optional | |||
| from typing import NamedTuple, Any, Dict | |||
chriselion
commented
Dec 11, 2019
| from mlagents.trainers.brain import AllBrainInfo, BrainParameters | ||
| from mlagents.trainers.policy import Policy | ||
| from mlagents.trainers.action_info import ActionInfo | ||
|
|
||
|
|
||
| class EnvironmentStep(NamedTuple): | ||
| previous_all_brain_info: Optional[AllBrainInfo] | ||
| previous_all_brain_info: AllBrainInfo |
chriselion
commented
Dec 11, 2019
| @@ -67,13 +67,14 @@ def __init__( | |||
| self.check_param_keys() | |||
|
|
|||
| if multi_gpu and len(get_devices()) > 1: | |||
| self.policy = MultiGpuPPOPolicy( | |||
| self.ppo_policy = MultiGpuPPOPolicy( | |||
There was a problem hiding this comment.
@ervteng This is what we talked about offline
chriselion
requested review from
ervteng and
vincentpierre
and removed request for
ervteng
vincentpierre
approved these changes
Dec 11, 2019
| from mlagents.trainers.brain import AllBrainInfo, BrainParameters | ||
| from mlagents.trainers.policy import Policy | ||
| from mlagents.trainers.action_info import ActionInfo | ||
|
|
||
|
|
||
| class EnvironmentStep(NamedTuple): | ||
| previous_all_brain_info: Optional[AllBrainInfo] | ||
| previous_all_brain_info: AllBrainInfo |
chriselion
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #3049
--namespace-packagesto the mypy settings for ml-agents