Skip to content

Clarify curriculum and behavior name #3380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 7, 2020
Merged

Clarify curriculum and behavior name #3380

merged 2 commits into from
Feb 7, 2020

Conversation

chriselion
Copy link
Contributor

This started out as a followup from https://forum.unity.com/threads/keyerror-when-training-with-curriculum.821835/#post-5445543

The documentation is also a bit unclear about the point that the behavior name also has an influence and is not only meant to find the .nn model.
maybe the parameter behavior name could be added and clarified here.

But then noticed some other missing fields.

andrewcoh
andrewcoh approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@andrewcoh andrewcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chriselion chriselion merged commit d70fb9d into release-0.14.0 Feb 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the release-0.14.0-curriculum-behavior-name branch February 7, 2020 02:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vincentpierre vincentpierre Awaiting requested review from vincentpierre

@harperj harperj Awaiting requested review from harperj

1 more reviewer

@andrewcoh andrewcoh andrewcoh approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriselion @andrewcoh