step logic changes: unit test #3467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriselion
commented
Feb 18, 2020
| @@ -487,10 +487,8 @@ public void TestCumulativeReward() | |||
| agent1.LazyInitialize(); | |||
| agent2.SetPolicy(new TestPolicy()); | |||
|
|
|||
| int expectedAgent1Resets= 0; | |||
There was a problem hiding this comment.
These were unused, and switch to var instead of int
chriselion
commented
Feb 18, 2020
| int expectedResets= 0; | ||
| int expectedAgentAction = 0; | ||
| int expectedAgentActionSinceReset = 0; | ||
| var expectedAgentStepCount = 0; |
There was a problem hiding this comment.
Added some extra checks on the step count and collectobservations calls.
chriselion
commented
Feb 18, 2020
| expectedAgentStepCount += 1; | ||
|
|
||
| // If the next step will put the agent at maxSteps, we expect it to reset | ||
| if (agent1.GetStepCount() == maxStep - 1 || (i == 0)){ |
There was a problem hiding this comment.
IMHO this is a little clearer (since it's a value on the actual Agent, not just a test variable)
10 tasks
surfnerd
reviewed
Feb 18, 2020
Co-Authored-By: Chris Goy <[email protected]>
delete-merged-branch
bot
deleted the
develop-modify-stepping-logic-test
branch
vincentpierre
added a commit
that referenced
this pull request
Feb 19, 2020
* Moving the max step logic - Created a new Academy Event called AgentIncrementStep to be called before SetStatus - Implemented the AgentSteping logic * second commit : Moving the step counting at the begining. I had to edit the tests but I think they are now closer to what we want * addressing comments * Update com.unity.ml-agents/Runtime/Agent.cs Co-Authored-By: Chris Goy <[email protected]> * Update com.unity.ml-agents/Runtime/Agent.cs Co-Authored-By: Chris Goy <[email protected]> * Made the tests not be broken * Update com.unity.ml-agents/Runtime/Agent.cs Co-Authored-By: Chris Elion <[email protected]> * step logic changes: unit test (#3467) * Added a line in the changelog Co-authored-by: Chris Goy <[email protected]> Co-authored-by: Chris Elion <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged into #3448