Skip to content

Rename --port commandline arg to --mlagents-port #3477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 20, 2020
Merged

Rename --port commandline arg to --mlagents-port #3477

merged 4 commits into from
Feb 20, 2020

Conversation

chriselion
Copy link
Contributor

@chriselion chriselion commented Feb 19, 2020 •
edited
Loading

Proposed change(s)

Change the command line argument from --port to --mlagents-port, to avoid potential conflicts with user command line args.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

https://jira.unity3d.com/browse/MLA-577

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • I have added tests that prove my fix is effective or that my feature works - manual test, plus the training yamato test will cover this.
  • I have added updated the changelog (if applicable)
  • I have added necessary documentation (if applicable)
  • I have updated the migration guide (if applicable)

Other comments

@chriselion chriselion requested a review from harperj February 19, 2020 19:44
harperj
harperj reviewed Feb 19, 2020
View reviewed changes
Copy link
Contributor

@harperj harperj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking that you're intending to change these project settings. Otherwise LGTM.

@chriselion chriselion requested a review from harperj February 19, 2020 19:57
harperj
harperj approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@harperj harperj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chriselion
Copy link
Contributor Author

(going to merge as soon as the "Fast Training" tests pass)

@chriselion chriselion merged commit 080afe3 into master Feb 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the develop-rename-port branch February 20, 2020 19:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@harperj harperj harperj approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriselion @harperj