Skip to content

Conversation

vincentpierre
Copy link
Contributor

Proposed change(s)

Gym was failing in single agent environments.
Revamped the notebooks a little bit

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

Copy link
Contributor

@chriselion chriselion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We should probably update unit test for the case we saw this afternoon, but can do that after.

@vincentpierre vincentpierre merged commit eb2a4a1 into master Feb 26, 2020
@delete-merged-branch delete-merged-branch bot deleted the hotfix-gym-notebook branch February 26, 2020 01:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants