[bug-fix] Re-record GridWorld Demo #3585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤦♂ Sorry, that was so that we test non-square observations (to make sure we don't mix up height and width). |
chriselion
approved these changes
Mar 7, 2020
chriselion
suggested changes
Mar 7, 2020
Done. |
surfnerd
approved these changes
Mar 9, 2020
This reverts commit 2f6b607.
surfnerd
approved these changes
Mar 9, 2020
chriselion
approved these changes
Mar 9, 2020
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
At some point the GridWorld environment was switched to 84x64 visual obs from 84x84, so the demo files no longer work. This PR updates the demo file.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Need to throw a better error when mismatched: (MLA-745)
Types of change(s)
Checklist
Other comments