Replaced get_behavior_names and get_behavior_spec with behavior_specs property

[vincentpierre]

Proposed change(s)

Replaced get_behavior_names and get_behavior_spec with behavior_specs property

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

• Bug fix
• New feature
• Code refactor
• Breaking change
• Documentation update
• Other (please describe)

Checklist

• Added tests that prove my fix is effective or that my feature works
• Updated the changelog (if applicable)
• Updated the documentation (if applicable)
• Updated the migration guide (if applicable)

Other comments

[andrewcoh]

Making it a property is much cleaner. Just curious as to the reason for creating BehaviorMapping. Is it just to have more explicit naming? From what I can tell it has the same functionality as a dictionary.

[vincentpierre]

Making it a property is much cleaner. Just curious as to the reason for creating BehaviorMapping. Is it just to have more explicit naming? From what I can tell it has the same functionality as a dictionary.

Using Mapping allows me to have this property be read only.

[chriselion]

Using Mapping allows me to have this property be read only.

Mapping is read-only (as opposed to MutableMapping), so using Mapping as the return type should be sufficient and you could just return self._env_specs in UnityEnvironment. It wouldn't be enforced at runtime, just by type checking and IDE syntax highlighting (but a user determined to mess things up could modify BehaviorMapping _dict too).

[vincentpierre]

Mapping is read-only (as opposed to MutableMapping), so using Mapping as the return type should be sufficient and you could just return self._env_specs in UnityEnvironment. It wouldn't be enforced at runtime, just by type checking and IDE syntax highlighting (but a user determined to mess things up could modify BehaviorMapping _dict too).

Would you recommend dropping the BehaviorMapping alltogether?
I think it is safer to do it this way, it makes it harder to mess up (while not impossible) which is better in my opinion.

[chriselion]

I think BehaviorMapping is overkill, but I'm not strongly opposed to it. I think having Mapping as part of the interface is the important part.

[chriselion]

nit: pretty sure you can do if not self._env.behavior_specs

[chriselion]

Looks good. Any documentation/examples that need to change too?

[vincentpierre]

Looks good. Any documentation/examples that need to change too?

Yes, coming soon

[vincentpierre]

Looks good. Any documentation/examples that need to change too?

@chriselion Made the documentation changes.