Skip to content

Conversation

ervteng
Copy link
Contributor

@ervteng ervteng commented Jun 1, 2020

Proposed change(s)

Update the Learning Environment guide (rollerball) with the latest hyperparameter format.

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

@ervteng ervteng requested a review from vincentpierre June 1, 2020 22:01
normalize: false
hidden_units: 128
num_layers: 2
vis_encode_type: simple
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is vis_encode_type needed ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No - removed

Comment on lines 411 to 412
learning_rate: 0.0003
beta: 0.0005
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it easier to read this way. Any reason this changed ?

Suggested change
learning_rate: 0.0003
beta: 0.0005
learning_rate: 3.0e-4
beta: 5.0e-3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not the standard YAML conversion, I think scientific notation isn't used until it's e-5 or more. But it will still load so I'm not opposed to changing it.

@ervteng ervteng merged commit f4d4848 into master Jun 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the develop-fixlearningenvdocs branch June 1, 2020 22:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants