Don't save model twice, copy instead #4302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harperj
approved these changes
Aug 5, 2020
| try: | ||
| shutil.copyfile(source_onnx_path, destination_onnx_path) | ||
| logger.info(f"Copied {source_onnx_path} to {destination_onnx_path}.") | ||
| except Exception: |
There was a problem hiding this comment.
Maybe handle the more specific exception(s)?
There was a problem hiding this comment.
I changed it to OSError, which covers FileNotFound (the one we'd expect when onnx not installed) and misc permissions errors.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Followup from #4127, retrying from #4298
After that PR, exiting during training would save twice, once when the checkpoint is saved, and once for the "final" model.
The bypasses the "final" save and just copies the checkpointed .nn file (and possibly .onnx too, if it exists).
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
#4127
Types of change(s)
Checklist
Other comments