Skip to content

Fix format of the changelog for validation. #4340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2020

Conversation

surfnerd
Copy link
Contributor

Proposed change(s)

Release 6 branch changelog fix

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@surfnerd surfnerd requested a review from chriselion August 11, 2020 23:46
@surfnerd surfnerd self-assigned this Aug 11, 2020
Copy link
Contributor

@chriselion chriselion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙄

@chriselion
Copy link
Contributor

Re-ran the failed tests and they passed. Github UI hasn't updated yet (webhook probably either delayed or dropped). Merging.

@chriselion chriselion merged commit 0d4d08c into release_6_branch Aug 12, 2020
@chriselion chriselion mentioned this pull request Aug 12, 2020
10 tasks
surfnerd added a commit that referenced this pull request Aug 12, 2020
* test initalize steps to 100

* use mean of first trajectory to initialize the normalizer

* remove blank line

* update changelog

* cleaned up initialization of variance/mean

* large normalization obs unit test

* add --upgrade to pip to get newer downloader (#4338)

* Fix format of the changelog for validation. (#4340)

Co-authored-by: Chris Elion <[email protected]>
Co-authored-by: Chris Goy <[email protected]>
@surfnerd surfnerd deleted the release_6_branch-changelog-fix branch August 14, 2020 00:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants