-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Add frozen flag to VisualFoodCollector #4511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Docs and changelogs WIP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you verified that it trains, this is great news!
I left a comment, please address before merging.
do you plan on adding this scene to the daily CI?
@@ -30,6 +30,7 @@ public class FoodCollectorAgent : Agent | |||
public GameObject myLaser; | |||
public bool contribute; | |||
public bool useVectorObs; | |||
public bool useFrozenFlag; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should always be turned on. The user might have issues with the number of observations when unchecking this box. Besides, you mentioned that the Agent will not train without it, so I think it should be always on and un-uncheckable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My concern was that it would be a bit confusing to use one vector flag by default in a "visual" scene.
Or is it actually not too big a problem? if so I can make it un-uncheckable.
Yes I think it would be good to be include in CI, so that we can capture it if we change the way combining vector and visual observations. It could take quite some time though. |
Added the trained model and updated the docs, so I think it'd be better to do re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks, good to me. I still think the useFrozenFlag should not be an option and should always be on. I tried the model and it worked. I did not try to train it.
Project/Assets/ML-Agents/Examples/FoodCollector/Scripts/FoodCollectorAgent.cs
Outdated
Show resolved
Hide resolved
Project/Assets/ML-Agents/Examples/FoodCollector/Scripts/FoodCollectorAgent.cs
Outdated
Show resolved
Hide resolved
…llectorAgent.cs Co-authored-by: Vincent-Pierre BERGES <[email protected]>
…llectorAgent.cs Co-authored-by: Vincent-Pierre BERGES <[email protected]>
Removed useFrozenFlag as suggested and verified the change does not affect the model. |
Proposed change(s)
The FoodCollector environment does not train with pure visual observation due to insufficient information. The agent lacks of information about the frozen state of itself, and adding a boolean flag indicating the frozen state (which is also used in the vector observation version of FoodCollector) makes the training work.
This will add an example of using both vector and visual observation to our example environments.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Checklist
Other comments