Add Graphics to the Match3 env #4627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
August 23, 2020 17:00
…echnologies/ml-agents into hh/develop/m3-graphics-m
chriselion
reviewed
Nov 9, 2020
|
|
||
| void OnDrawGizmos() | ||
| { | ||
| // TODO replace Gizmos for drawing the game state with proper GameObjects and animations. | ||
| var cubeSize = .5f; | ||
| var cubeSpacing = .75f; | ||
| var matchedWireframeSize = .5f * (cubeSize + cubeSpacing); | ||
| var matchedWireframeSize = .5f * (cubeSize + CubeSpacing); |
There was a problem hiding this comment.
Do we even need the gizmos code anymore?
There was a problem hiding this comment.
Even if we want to keep it around, you can remove the TODO above :)
There was a problem hiding this comment.
changed: removed the todo. also, the gizmos still show some of the debug features you made. there's still value there so i'd say we can leave for now
chriselion
approved these changes
Nov 9, 2020
i brought them in as 3 separate meshes so i could independently scale the 3 so this was intended |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Adds Graphics to the M3 env. Spawns gameobject "tiles" in game mode. Added image to the Match3 docs.
Types of change(s)
Checklist
Other comments