Skip to content

Added subarray material #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 18, 2021
Merged

Conversation

ananya0504
Copy link
Contributor

Fixes #118

Short description of what this resolves:

improve: Subarrays

What Changes proposed in this pull request:

  • Added material for the subarrays lesson in Java
  • Explained what subarrays are.
  • Explained how to generate subarrays using an iterative approach
  • Explained how to generate subarrays using a recursive approach.

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added code examples, test must pass
  • Added documentation so that the program is self-explanatory and educational.
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:
This lesson contains information about subarrays in Java

Copy link
Owner

@Utkarsh1504 Utkarsh1504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ananya0504 Please do the suggested changes, else everything looks nice.

@Utkarsh1504
Copy link
Owner

Also, remove the first heading as it will be there by default on the site. Thank you

@ananya0504
Copy link
Contributor Author

Hi @Utkarsh1504
I have improved upon the language.
Added a few extra changes by myself so that the language is easily understandable to the readers.
Also, worked on the formatting as you suggested! Thanks a lot :)

Copy link
Owner

@Utkarsh1504 Utkarsh1504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! 👍🏻 Thank you and keep contributing.

@Utkarsh1504 Utkarsh1504 added approved for approved PRS hacktoberfest-accepted eligible PRs for hactoberfest ✅ Ready for merge approved pull request and removed requested-change labels Oct 18, 2021
@Utkarsh1504 Utkarsh1504 merged commit b76a503 into Utkarsh1504:main Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved for approved PRS hacktoberfest-accepted eligible PRs for hactoberfest ✅ Ready for merge approved pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve: Subarrays
2 participants