Skip to content

WIP: Added prevent error logging option #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

WIP: Added prevent error logging option #457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9b527d
Added ignore error option
Feb 28, 2025
5c581ee
fixed condition
Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/request/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ function request<D = unknown>(
}
})

.catch((err) => log.error('request', err));
.catch((err) => opts.logError?.(err) === false ? undefined : log.error('request', err));

resolve(ctx.wrapRequest(resultPromise));

Expand Down
9 changes: 9 additions & 0 deletions src/core/request/interface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,6 +522,15 @@ export interface CreateRequestOptions<D = unknown> {
*/
important?: boolean;

/**
* By default, request errors are sent to the logger. However, sometimes
* certain errors should not be logged. To disable logging for specific errors,
* use this parameter. If it returns `false`, the error will not be logged.
*
* @param error - The error that occurred during the request.
*/
logError?(error?: RequestError | unknown): boolean;

/**
* A request engine to use.
* The engine - is a simple function that takes request parameters and returns an abortable promise resolved with the
Expand Down
Loading