[TF2] Add a Server ConVar for the forced aim level of Spy Robots in MvM

[AJMickey]

Within tf_bot_body.cpp ( src / game / server / tf / bot /tf_bot_body.cpp ), there is code that makes it so that if the game mode is Mann vs Machine, Spy robots will always have a forced aim level of 0.25f, i.e. they will adjust their aim 4 times every second.

This can be undesirable for mission makers, as it effectively hard-limits a Spy Robot's efficacy with Revolvers. For example, many Giant Robots tend to have Expert skill - yet if one were to make a Giant Revolver Spy with Expert skill, e.g. in community missions, their accuracy would be capped at Normal-difficulty levels (Normal AI has 0.25f), making them far weaker than intended. Mission creators who want high-accuracy Spy robots often have to make hacky workarounds or rely on external plugins, which is inconvenient.

Oh, and this does also mean Easy AI Spies have 4x better aim than they otherwise would, I suppose

Basically, I am requesting for there to be a Server ConVar added to enable/disable this behaviour. 0 would be disabled, 1 would be enabled. 1 should be the default, as the limit was added for a reason, and many community missions have already been designed with this forced aim level in mind. This would mostly be nice for future missions that could make use of such a ConVar.

[FlaminSarge]

Would this not be better as a (CTFBot) Attribute that can be added to spies to allow their aim to respect their skill setting?

In fact: ValveSoftware/source-sdk-2013#1520

[AJMickey]

Oh, yes, that's probably better, thank you!