Add C_BaseEntity::CanGlow to opt-out of glowing for Sentry Gun shield
#1508
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 57a8b64, the Sentry Gun's shield became a client entity that is moveparented to the Sentry Gun, which made it inherit the glow, entirely occluding the Sentry Gun's own glow. This prevents the shield from having a glow.
Bitl
added a commit
to BitlDevelopmentStudios/source-sdk-2013-bds-base
that referenced
this pull request
Aug 25, 2025
|
Though an unintended side effect of a change, it isn't necessarily a bad one I feel. Is there a particular reason the original behavior should be maintained? |
Since the shield masks the sentry model's glow outline, the player loses information on what level the sentry is, which IMO is more important than knowing whether it is wrangled or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix was requested from me by a community member reporting bugs for CastingEssentials Next.
Before (caused by 57a8b64)
After