Add some tensor dtype convert APIs #576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For pre/post process. Type: Code Refine
sunshinemyson
approved these changes
Apr 25, 2023
src/tim/vx/tensor.cc
Outdated
| /**************************************************************************** | ||
| * | ||
| * Copyright (c) 2020-2023 Vivante Corporation | ||
| * Copyright (c) 2020 Vivante Corporation |
There was a problem hiding this comment.
copyright should not changed.
src/tim/vx/tensor.cc
Outdated
| #define ENABLE_TENSOR_HNDL 1 | ||
| #endif | ||
|
|
||
| #include <stdio.h> |
include/tim/vx/tensor.h
Outdated
| virtual void unmap() = 0; | ||
| virtual bool IsPlaceHolder() = 0; | ||
| virtual bool IsConstTensor() = 0; | ||
| virtual const void* GetDataRef() const = 0; |
There was a problem hiding this comment.
Add a comment for GetDataRef() since this is an dangerous API.
Comment: "Never use this api expect AcuityLite codegen"
include/tim/vx/tensor.h
Outdated
| virtual bool IsPlaceHolder() = 0; | ||
| virtual bool IsConstTensor() = 0; | ||
| virtual const void* GetDataRef() const = 0; | ||
| virtual bool SaveTensorToTextByFp32(const char* filename) = 0; |
There was a problem hiding this comment.
Suggest use SaveAsRawFp32( std::ostream& os);
For file operation, you can use ofstream from generated code.
include/tim/vx/tensor.h
Outdated
| virtual bool IsConstTensor() = 0; | ||
| virtual const void* GetDataRef() const = 0; | ||
| virtual bool SaveTensorToTextByFp32(const char* filename) = 0; | ||
| virtual bool Float32ToDtype(float fval, uint8_t* tensorData, uint32_t stride) = 0; |
There was a problem hiding this comment.
Should not be
namespace tim::vx::utils {
float32ToDtype(const std::vector&, uint8_t* destData, TensorSpec& targetSpec);
or
static function of tensor class
}
sunshinemyson
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For pre/post process.
Type: Code Refine