-
Notifications
You must be signed in to change notification settings - Fork 145
Add warnings for -save
& -nosave
legacy scala
runner options instead of failing
#1679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8fbd491
to
abb02a2
Compare
tgodzik
reviewed
Dec 15, 2022
modules/cli/src/main/scala/scala/cli/commands/default/LegacyScalaOptions.scala
Outdated
Show resolved
Hide resolved
lwronski
reviewed
Dec 15, 2022
modules/cli/src/main/scala/scala/cli/commands/default/LegacyScalaOptions.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/commands/default/Default.scala
Outdated
Show resolved
Hide resolved
julienrf
reviewed
Dec 16, 2022
modules/cli/src/main/scala/scala/cli/commands/default/LegacyScalaOptions.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/commands/default/LegacyScalaOptions.scala
Outdated
Show resolved
Hide resolved
37b636c
to
60fac13
Compare
This was referenced Dec 16, 2022
60fac13
to
ade1c51
Compare
julienrf
reviewed
Dec 16, 2022
modules/cli/src/main/scala/scala/cli/commands/default/LegacyScalaOptions.scala
Outdated
Show resolved
Hide resolved
julienrf
approved these changes
Dec 16, 2022
…stead of failing
ade1c51
to
a265db7
Compare
lwronski
approved these changes
Dec 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
relevant docs will be added as part of #1721 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
SIP-46
All the issues related to SIP-46 to turn Scala CLI into the official scala runner command.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1670
for
scala-cli
:for
scala
(SIP mode):