Add warnings for the deprecated -Yscriptrunner legacy scala runner option instead of passing it to scalac
#1804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gedochao
added
the
SIP-46
Gedochao
force-pushed
the
yscriptrunner
branch
from
82a4008 to
51d76f3
Compare
lwronski
approved these changes
Jan 26, 2023
modules/cli/src/main/scala/scala/cli/commands/shared/ScalacOptions.scala
Outdated
Show resolved
Hide resolved
Gedochao
force-pushed
the
yscriptrunner
branch
from
51d76f3 to
5023f05
Compare
…stead of passing it to `scalac`
Gedochao
force-pushed
the
yscriptrunner
branch
from
5023f05 to
b89176b
Compare
lwronski
pushed a commit
to lwronski/scala-cli
that referenced
this pull request
Feb 9, 2023
…stead of passing it to `scalac` (VirtusLab#1804)
tgodzik
pushed a commit
to tgodzik/scala-cli
that referenced
this pull request
Feb 13, 2023
…stead of passing it to `scalac` (VirtusLab#1804)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1721
Depends on #1801 (relies on some of the refactors from there)
Despite the
-Yprefix,-Yscriptrunneris actually ascalarunner option (and not ascalacoption) and thus will be covered as part of #1721.Up until now, Scala CLI has been assuming it's a
scalacoption and has been passing it to the compiler.However, the compiler doesn't know what to do with it.
With these changes, we'll be logging a reasonable warning about the option being deprecated and no longer supported in Scala CLI (it being the new
scalarunner). We'll no longer pass the option to the compiler, either.