Skip to content

Fallback to UTF-8 in setup-ide #2599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

JD557
Copy link
Contributor

@JD557 JD557 commented Nov 30, 2023

Uses UTF-8 as the default charset in setup-ide as that seems to be the format expected by the other tools (such as metals).

Closes #2598

@JD557
Copy link
Contributor Author

JD557 commented Nov 30, 2023

I'm not really sure why the CI is failing. I see:

Thu, 30 Nov 2023 21:43:09 GMT ==> X sclicheck.DocTests.command basics  32.382s sclicheck.FailedCheck: [website/docs/commands/basics.md:320] Commands failed.
Thu, 30 Nov 2023 21:43:09 GMT     at sclicheck.FailedCheck$.apply(sclicheck.scala:64)
Thu, 30 Nov 2023 21:43:09 GMT     at sclicheck.sclicheck$package$.check(sclicheck.scala:68)
Thu, 30 Nov 2023 21:43:09 GMT     at sclicheck.sclicheck$package$.runCommand$1(sclicheck.scala:251)
Thu, 30 Nov 2023 21:43:09 GMT     at sclicheck.sclicheck$package$.checkFile$$anonfun$1(sclicheck.scala:310)
Thu, 30 Nov 2023 21:43:09 GMT     at scala.collection.immutable.Vector.foreach(Vector.scala:1895)
Thu, 30 Nov 2023 21:43:09 GMT     at sclicheck.sclicheck$package$.checkFile(sclicheck.scala:317)
Thu, 30 Nov 2023 21:43:09 GMT     at sclicheck.DocTests.$init$$$anonfun$3$$anonfun$1$$anonfun$1(DocTests.scala:36)

I assumed this meant that I need to run ./mill -i generate-reference-doc.run, but that doesn't seem to change anything...

@JD557
Copy link
Contributor Author

JD557 commented Dec 1, 2023

Oh, looks like it might have been a flaky test, thanks for re-triggering the build. :)

Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Some context: we use UTF-8 everywhere, so this makes sense.
We should make it customisable at some point, the relevant ticket to track is #1390

@Gedochao Gedochao merged commit 9f95620 into VirtusLab:main Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scala-cli setup-ide generates files in latin-1 instead of utf-8
2 participants