Skip to content

Apply scalafix rules to test scope inputs, too #3641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

Gedochao
Copy link
Contributor

@Gedochao Gedochao commented Apr 15, 2025

Fixes #3640

The test scope simply wasn't being built for scalafix, so no wonder the semanticdb files were missing.
There's some follow-up refactoring I'd like to do in a future PR, but for the bugfix itself, this should do the trick.

@Gedochao Gedochao force-pushed the feature/scalafix-test-scope branch 2 times, most recently from d7df88e to 2ca309e Compare April 15, 2025 16:07
@Gedochao Gedochao marked this pull request as ready for review April 15, 2025 16:09
@Gedochao Gedochao requested a review from tgodzik April 15, 2025 16:09
@Gedochao Gedochao force-pushed the feature/scalafix-test-scope branch from 2ca309e to 528b8c9 Compare April 15, 2025 16:10
Copy link
Member

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodzik tgodzik merged commit 2a7023e into VirtusLab:main Apr 16, 2025
54 checks passed
@Gedochao Gedochao deleted the feature/scalafix-test-scope branch April 24, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SemanticDB not generated for test classes when running fix command
2 participants