Skip to content

Perf/pie chart performance #2575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Perf/pie chart performance #2575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2e71f3
perf: optimize the performance of pie chart, fix #2568
xile611 Apr 22, 2024
87e139a
docs: update changlog of rush
xile611 Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/@visactor/vchart/perf-pie-chart-performance_2024-04-22-07-28.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "perf: optimize the performance of pie chart, fix #2568\n\n",
"type": "none",
"packageName": "@visactor/vchart"
}
],
"packageName": "@visactor/vchart",
"email": "[email protected]"
}
3 changes: 2 additions & 1 deletion packages/vchart/src/data/transforms/pie.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ export const pie = (originData: Array<DataView>, op: IPieOpt) => {
let lastAngle = startAngle;
let restAngle = angleRange;
let largeThanMinAngleTotal = 0;
const percents = getPercentValue(valueList);

data.forEach((d, i) => {
const angleFieldValue = d[ARC_TRANSFORM_VALUE];
Expand All @@ -87,7 +88,7 @@ export const pie = (originData: Array<DataView>, op: IPieOpt) => {

d[asRatio] = ratio;
d[asK] = max ? angleFieldValue / max : 0;
d._percent_ = getPercentValue(valueList, i);
d._percent_ = percents[i];
appendArcInfo(d, dStartAngle, radian);

lastAngle = dEndAngle;
Expand Down
8 changes: 2 additions & 6 deletions packages/vchart/src/util/math.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,11 +248,7 @@ export function distance(p1: IPoint, p2: IPoint = { x: 0, y: 0 }) {
/**
* 最大余额法计算百分比
**/
export function getPercentValue(valueList: number[], idx: number, precision = 2) {
if (!valueList[idx]) {
return 0;
}

export function getPercentValue(valueList: number[], precision = 2) {
const sum = valueList.reduce((a, c) => {
return (a += isNaN(c) ? 0 : c);
}, 0);
Expand Down Expand Up @@ -293,5 +289,5 @@ export function getPercentValue(valueList: number[], idx: number, precision = 2)
++currentSum;
}

return seats[idx] / digits;
return seats.map(entry => entry / digits);
}