Skip to content

Conversation

kkxxkk2019
Copy link
Collaborator

@kkxxkk2019 kkxxkk2019 commented May 13, 2024

  1. CartesianMarkLine 类中的 _markLayout 是覆写 BaseMarkLine 基类的 _markLayout 方法,无需调用父类,一是这样会导致标注多次更新,二是导致在图表编辑器场景因为会有较频繁的图表更新操作,导致标注更新报错
  2. 抽象公共方法,优化代码
  3. 修复标注的更新逻辑

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Release
  • Site / documentation update
  • Demo update
  • Workflow
  • Other (about what?)

🐞 Bugserver case id

66432b2e0b3b8900c63a7841

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

@kkxxkk2019 kkxxkk2019 requested a review from skie1997 May 13, 2024 13:55
@github-actions github-actions bot added the chore label May 14, 2024
@kkxxkk2019 kkxxkk2019 requested a review from xile611 May 14, 2024 09:16
@kkxxkk2019 kkxxkk2019 changed the title fix: remove repeated _markerLayout fix: 标注更新问题修复 May 14, 2024
@xile611 xile611 merged commit 4886bb6 into develop May 15, 2024
@xile611 xile611 deleted the fix/repeated branch May 15, 2024 03:39
@xile611 xile611 modified the milestones: 1.12.0, 1.11.1 May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants